Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update device.coffee #50

Merged
merged 5 commits into from May 24, 2014

Conversation

Projects
None yet
2 participants
Contributor

lotterfriends commented Feb 5, 2014

The Portrait/Landscape Detection did not work, due to the different implementation of the device manufacturers of window.orientation

lotterfriends added some commits Feb 5, 2014

@lotterfriends lotterfriends Update device.coffee
The Portrait/Landscape Detection did not work, due to the different implementation of the device manufacturers of window.orientation
5ebb4df
@lotterfriends lotterfriends Update device.coffee
RTrim unnecessary Whitespaces
cd0e2b4
@lotterfriends lotterfriends Update package.json
Update Version Number to 0.1.59
63a0ee8
@lotterfriends lotterfriends Update README.markdown
Added device.desktop()
81a2cd9
Owner

matthewhudson commented Feb 6, 2014

@lotterfriends Looks like a decent enough workaround.

Let me see if I can figure out a way to write some tests before I merge. If you have any ideas in this regard - I'm all ears. See here: #17

@lotterfriends lotterfriends Update device.coffee
create device.desktop()
168bf41

@matthewhudson matthewhudson added a commit that referenced this pull request May 24, 2014

@matthewhudson matthewhudson Merge pull request #50 from lotterfriends/master
Refined Portrait/Landscape Detection
0744750

@matthewhudson matthewhudson merged commit 0744750 into matthewhudson:master May 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment