Permalink
Commits on Nov 2, 2017
  1. 1.0.18 version bump

    mattheworiordan committed Nov 2, 2017
  2. Add support for selenium_chrome{,_headless}

    jhawthorn committed with mattheworiordan Sep 8, 2017
    As of capybara 2.15.0 there are built-in drivers for :selenium_chrome
    and :selenium_chrome_headless
  3. Fix Travis failures for Ruby 2.0

    mattbrictson committed with mattheworiordan Aug 1, 2017
    A handful of gems needed in the tests no longer support Ruby 2.0,
    which causes Travis builds to fail. Work around this by pinning older
    versions of those gems when running on Ruby 2.0
  4. Ensure screenshot taken on expect() failures

    mattbrictson committed with mattheworiordan Jul 28, 2017
    Starting with RSpec 3.3.0, `expect()` failures do not raise an
    exception immediately. Instead each failure is recorded in a thread-
    local "aggregator" and then raised at end of the example.
    
    This interferes with capybara-screenshot because `after` hooks execute
    *before* these aggregated failures are raised. In other words, in the
    `after` block `example.exception` will be `nil`. This makes capybara-
    screenshot think that the example hasn't failed, and thus it does not
    take a screenshot, even though there are actual failures.
    
    This commit works around this problem by using some behind-the-scenes
    knowledge of how rspec-expectations does the aggregation. Now we reach
    into the thread-local storage (`RSpec::Support.failure_notifier`) and
    discover whether there are in fact failures "queued up". If so, we will
    consider the example to have failed and take a screenshot.
Commits on Jul 28, 2017
  1. in rspec, only test Capybara.page.current_url when there is an expect…

    yanowitz committed with mattheworiordan Dec 8, 2016
    …ation exception
    
      The previous logic meant every test (even ones that didn't use Capybara) caused the page to open.
Commits on Jul 17, 2017
  1. Version bump

    mattheworiordan committed Jul 17, 2017
Commits on Jul 16, 2017
  1. Add one more test

    ywen committed with mattheworiordan Jul 15, 2017
    To describe that only one warning is printed
  2. Address review comment

    ywen committed with mattheworiordan Jul 15, 2017
    1. Do raise if save_page fails
    2. print warn message
  3. Add tests

    ywen committed with mattheworiordan Jun 27, 2017
  4. Fix a logic error

    ywen committed with mattheworiordan Jun 27, 2017
  5. Try a travis build

    ywen committed with mattheworiordan Jun 27, 2017
  6. Do not rise if selenium raises

    ywen committed with mattheworiordan Jun 26, 2017
    This can be handled by spinach
Commits on Jul 12, 2017
  1. Version bump

    mattheworiordan committed Jul 12, 2017
  2. Update travis script

    ericgriffis committed with mattheworiordan Feb 23, 2017
  3. Update readme

    ericgriffis committed with mattheworiordan Feb 23, 2017
  4. Gem version bump

    mattheworiordan committed Jul 12, 2017
Commits on Jul 4, 2017
Commits on Apr 3, 2017
  1. Ensure the reporter module is not loaded multiple times when (#205)

    ArturT committed with mattheworiordan Apr 3, 2017
    before(:suite) is run multiple times because of using RSpec::Core::Runner
    
    Related issue: buildkite/docs#99
Commits on Nov 17, 2016
  1. fix typo in readme

    hupf committed with mattheworiordan Nov 17, 2016
Commits on Sep 21, 2016
  1. Merge pull request #175 from glaszig/fix/test-suite

    mattheworiordan committed Sep 21, 2016
    fix test suite
  2. Merge pull request #171 from glaszig/callbacks

    mattheworiordan committed Sep 21, 2016
    after_save_html and after_save_screenshot callbacks
Commits on Sep 15, 2016