Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

divide by zero exception in wav_convert2mono in wav.c #57

Open
92wyunchao opened this issue Jul 8, 2018 · 1 comment
Open

divide by zero exception in wav_convert2mono in wav.c #57

92wyunchao opened this issue Jul 8, 2018 · 1 comment

Comments

@92wyunchao
Copy link

92wyunchao commented Jul 8, 2018

one divide by zero exception in wav_convert2mono in wav.c which allows attacker to cause a denial of service.

poc file:
poc.tar.gz

To reproduce:
./wav2swf -o output $poc

ASan:
==73857==ERROR: AddressSanitizer: FPE on unknown address 0x000000521455 (pc 0x000000521455 bp 0x7ffcdcbbc3d0 sp 0x7ffcdcbbc2d0 T0)
#0 0x521454 in wav_convert2mono (/home/s2e/asan/swftools-master/src/wav2swf+0x521454)
#1 0x4eb5e1 in main (/home/s2e/asan/swftools-master/src/wav2swf+0x4eb5e1)
#2 0x7f5de893d82f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/../csu/libc-start.c:291
#3 0x419658 in _start (/home/s2e/asan/swftools-master/src/wav2swf+0x419658)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: FPE (/home/s2e/asan/swftools-master/src/wav2swf+0x521454) in wav_convert2mono
==73857==ABORTING

yoya added a commit to yoya/swftools that referenced this issue Jan 17, 2020
Avoid div 0 of align as denominator in samplelen calculation.
ref) matthiaskramm#57
yoya added a commit to yoya/swftools that referenced this issue Jan 17, 2020
Avoid div 0 of align as denominator in samplelen calculation.
ref) matthiaskramm#57
@yoya
Copy link
Contributor

yoya commented Jan 17, 2020

The following PR will solve this issue.
#77

matthiaskramm pushed a commit that referenced this issue Jan 17, 2020
Avoid div 0 of align as denominator in samplelen calculation.
ref) #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants