New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded symbols #19

Closed
mattiadg opened this Issue Oct 14, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@mattiadg
Owner

mattiadg commented Oct 14, 2018

In the code there are symbols like '.' in the board representation or magic numbers that should be changed into variable names.
This is good for newcomers.

@MuchtarSalimov

This comment has been minimized.

MuchtarSalimov commented Oct 14, 2018

May I work on this?

I plan to follow the style seen here and just add them to the header files:
const int BOARD_SIZE = 9;

@mattiadg

This comment has been minimized.

Owner

mattiadg commented Oct 14, 2018

Great, it's yours.

@mattiadg

This comment has been minimized.

Owner

mattiadg commented Oct 15, 2018

Addressed in #24 . Closing till the merging.

@mattiadg mattiadg closed this Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment