Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add List #18

Merged
merged 1 commit into from
Aug 10, 2016
Merged

Add List #18

merged 1 commit into from
Aug 10, 2016

Conversation

alitaheri
Copy link
Collaborator

No description provided.

@mattiamanzati mattiamanzati mentioned this pull request Aug 10, 2016
39 tasks
rightIconButton?: React.ReactElement<any>;
rightToggle?: React.ReactElement<any>;
secondaryText?: React.ReactNode;
secondaryTextLines?: number; // 1 or 2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this actually be "1 | 2" ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would need typescript 2, a lot of people haven't/won't migrate. I'd say give this feature a couple of month.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair, I've been using it for a while, let's give time to people! :)

@alitaheri alitaheri merged commit 3803671 into mattiamanzati:master Aug 10, 2016
@alitaheri alitaheri deleted the add-list branch August 10, 2016 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants