Add Category:Swedish Cyprus Expedition to all non-categorized images #34
Conversation
create_infotexts.py
Outdated
| @@ -367,8 +369,8 @@ def process_depicted_place(self, place_string, places_mapping): | |||
| place_as_wikitext = place_string | |||
|
|
|||
| # Don't forget to add the commons categories, even though only wikidata is used in depicted people field | |||
| if places_mapping[place_string].get('commonscat'): | |||
| self.content_cats.append(places_mapping[place_string]["commonscat"]) | |||
| if places_mapping[place_string].get('commonscat'): | |||
There was a problem hiding this comment.
I would avoid making this change here since it is unrelated to what you want to do and will make this PR collide with the other patches.
There was a problem hiding this comment.
OK, created new task not to forget it and reverted the change.
create_infotexts.py
Outdated
|
|
||
| :return: None (populates self.content_cats) | ||
| """ | ||
| if not self.content_cats: |
There was a problem hiding this comment.
Do you also want to add a metacategory (needs more categories)?
There was a problem hiding this comment.
Very true! Done!
create_infotexts.py
Outdated
| """" | ||
| Check if there are any content cats added and add generic content category to image. | ||
|
|
||
| :return: None (populates self.content_cats) |
There was a problem hiding this comment.
Don't describe this as a return. You can just have populates self.content_cats as part of the docstring (on it's own line)
There was a problem hiding this comment.
In addition to the in-line comment you also haven't reverted the change mentioned in #34 (comment)
create_infotexts.py
Outdated
| @@ -435,6 +437,15 @@ def process_region_addition_to_description(region_str, country_str): | |||
|
|
|||
| return region_addition | |||
|
|
|||
| def add_catch_all_category(self, item): | |||
| """" | |||
| Populate self.content_cat with commons category, if present. | |||
There was a problem hiding this comment.
I meant that you could add this instead of the None I would still keep the original first line of the docstring though.
Also there should be no empty lines towards the end of the docstring (just one between the first line and the rest.
There was a problem hiding this comment.
Ah, OK. Done.
Task: https://phabricator.wikimedia.org/T163534