Tidied up the "If" logic #1

Merged
merged 1 commit into from Aug 14, 2011

2 participants

@jackfranklin

Hey Matt,

Nice plugin! Just spotted a couple of things I wanted to tweak, mainly the logic of the ternary statements, such as:

return (($this.is('ul, ol')) ?  true : false);

Here you're checking the value of $(this).is('ul, ol') which returns true or false, so no need to return T/F based on the result of it, you can just return it :)

This happened on about 3 occasions, edited them all and tested it, seems to still be fine.

Cheers!

@mattkersley mattkersley merged commit 3889b69 into mattkersley:master Aug 14, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment