Skip to content
This repository has been archived by the owner. It is now read-only.

Provide an easier + more consistent way of overriding directive templates #236

Closed
mattlewis92 opened this Issue Dec 15, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@mattlewis92
Copy link
Owner

mattlewis92 commented Dec 15, 2015

  • Change the current calendarConfig provider to a plain angular constant where variables can be overridden in the config block
  • Create a new entry point that loads templates into the template cache rather than directly including them with webpack
  • In the new constant allow setting the template urls
  • Docs + breaking change commit

@mattlewis92 mattlewis92 self-assigned this Dec 15, 2015

mattlewis92 pushed a commit that referenced this issue Dec 30, 2015

Matt Lewis
feat(calendarConfig): change the calendarConfig provider to a plain o…
…bject. Part of #236

BREAKING CHANGE:
`calendarConfig` is now just a plain angular value. The helper methods were removed and now you directly set the properties on a plain object.

Before:
```
.config(function(calendarConfigProvider) {
  calendarConfigProvider.setDateFormatter('moment');
});
```

After:
```
.config(function(calendarConfig) {
  calendarConfig.dateFormatter = 'moment';
});
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.