Skip to content
This repository has been archived by the owner. It is now read-only.

Open Month SlideBox Indexes Not Updated on Month Change #426

Closed
ptrckc opened this Issue Aug 19, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@ptrckc
Copy link

ptrckc commented Aug 19, 2016

To reproduce, follow these steps:

See: http://plnkr.co/edit/p7NprlUw3AdUTe0C0Blm?p=preview

  • Aug. 19, 2016 will be selected by default and the slide box open to the date.
  • Click "Previous" to go back 1 month to July.
  • Jul. 19, 2016 should now be selected. However, the slide box remains positioned at the row/day index of Aug. 19 (now Jul. 15) instead of refreshing to select the new view date of Jul. 19.

On line 23 of MwlCalendarMonthCtrl, removing " && vm.openRowIndex === null" on the if check should take care of fixing this issue.

@mattlewis92

This comment has been minimized.

Copy link
Owner

mattlewis92 commented Aug 20, 2016

Thanks for the detailed repro, I think the best solution here is to change the behaviour of the slidebox to match the angular2 implementation of this module, whereby the slidebox will only open when the cell date === the view-date and cell-is-open is true (and disable all the auto opening / closing of the slidebox)

@mattlewis92 mattlewis92 added the bug label Aug 20, 2016

@mattlewis92 mattlewis92 added this to the 0.24.x milestone Aug 20, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.