Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(week-view): 5 days semi-weeks #570
It would be great if you could help me to review the new code.
Also, I am not sure how to fix one failing test ( to be honest that view I do not need, so I left the investigation over). Perhaps you could have an idea how to fix it. I guess it would be for you super easy.
Anyway, thanks for your feedback!
Thanks this looks good! I don't have time to properly review it right now, however there are a couple of things I can see that you can work on now:
Thanks for your message.
ad 1) I need to somehow used this feature within my project, so until we merge this PR, will keep it there. (but yes I agree with you:)
ad 2) Sure, will remove it. (was there just temporary)
ad 3) calendar-utils support excluding, that is great, but it is a quite a messy to use it for this feature (initially I used but the algorithm to choose excluded days became very smelly).
So, I wound prefer to keep approaches transparent and not to reuse them. They have in my opinion different meanings. Do you see my point? And also, this should be in theory faster (instead of excluding, we are just iterating less days..)
Anyway, look forward hearing from you!