Skip to content
This repository has been archived by the owner. It is now read-only.

fix(dragSelect): ignore right-clicks for drag/drop #585

Merged
merged 3 commits into from Apr 24, 2017

Conversation

Projects
None yet
3 participants
@bwobbones
Copy link
Contributor

bwobbones commented Apr 23, 2017

This actually the solution to #575.

The drag and drop events are all handled regardless of mouse button. This change makes sure that the right click is ignored, allowing the separation of right click events through oncontextmenu.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 23, 2017

Codecov Report

Merging #585 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #585   +/-   ##
=======================================
  Coverage   95.93%   95.93%           
=======================================
  Files          26       26           
  Lines         714      714           
=======================================
  Hits          685      685           
  Misses         29       29
Impacted Files Coverage Δ
src/directives/mwlDragSelect.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8ffc2b...3ae6a42. Read the comment docs.

@bwobbones bwobbones changed the title Ignore mouse right-clicks when dragging and dropping fix(dragSelect): ignore right-clicks for drag/drop Apr 23, 2017

@mattlewis92
Copy link
Owner

mattlewis92 left a comment

LGTM, can you remove the dist files from the commit though please, as these get auto generated on release. Thanks! 😄

Greg Lucas-Smith

@mattlewis92 mattlewis92 merged commit e0a51b6 into mattlewis92:master Apr 24, 2017

3 checks passed

codecov/patch 100% of diff hit (target 95.93%)
Details
codecov/project 95.93% (+0%) compared to e8ffc2b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.