New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Chumpy installation #15

Merged
merged 3 commits into from Aug 29, 2017

Conversation

Projects
None yet
3 participants
@tzaman

tzaman commented Aug 3, 2017

As noted in #13 the installation is currently broken, as setup.py tries to import chumpy to get the version string, which fails when any of chumpy's own requirements aren't installed beforehand.

This fixes the issue by using execfile to directly grab the version string from version.py instead of attempting to import the actual chumpy package. Some minor markdown updates to the README file are also included.

@raffienficiaud

This comment has been minimized.

Show comment
Hide comment
@raffienficiaud

raffienficiaud Aug 3, 2017

Contributor

should fix #13

Contributor

raffienficiaud commented Aug 3, 2017

should fix #13

@tzaman

This comment has been minimized.

Show comment
Hide comment
@tzaman

tzaman Aug 24, 2017

Ping. Any chance we can get this merged?

tzaman commented Aug 24, 2017

Ping. Any chance we can get this merged?

@mattloper mattloper merged commit 58a76a8 into mattloper:master Aug 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment