Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronize access to Console (fixes #48) #49

Merged
merged 1 commit into from Jun 26, 2020

Conversation

@segrey
Copy link
Contributor

@segrey segrey commented Apr 28, 2020

No description provided.

@Fenny
Copy link

@Fenny Fenny commented Jun 22, 2020

@mattn willing to take a quick look? Seems to be a valid PR 👍

@@ -430,8 +431,14 @@ func atoiWithDefault(s string, def int) (int, error) {
return strconv.Atoi(s)
}

var (
writeMutex sync.Mutex
Copy link
Owner

@mattn mattn Jun 24, 2020

This mutex have to be a field of Writer.

Copy link
Contributor Author

@segrey segrey Jun 25, 2020

Thanks, fixed

@segrey segrey force-pushed the sync-access-to-console branch from e8149f0 to 94e912b Jun 25, 2020
@segrey segrey force-pushed the sync-access-to-console branch from 94e912b to b6d341e Jun 25, 2020
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 25, 2020

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files           2        2           
  Lines          40       40           
=======================================
  Hits           36       36           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1b5a0e...b6d341e. Read the comment docs.

@mattn mattn merged commit f6c0098 into mattn:master Jun 26, 2020
3 checks passed
@mattn
Copy link
Owner

@mattn mattn commented Jun 26, 2020

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants