Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set termio in IsTerminal on solaris #61

Merged
merged 1 commit into from May 26, 2021

Conversation

tklauser
Copy link
Contributor

@tklauser tklauser commented May 26, 2021

The current implementation of IsTerminal on solaris uses IoctlSetTermio
which will set a zero valued termio on the given FD. This might lead to
unexpected side effects. Instead, use IoctlGetTermio which will not
change the terminal settings.

Also adjust the reference to isatty in the Illumos source.

The current implementation of IsTerminal on solaris uses IoctlSetTermio
which will set a zero valued termio on the given FD. This might lead to
unexpected side effects. Instead, use IoctlGetTermio which will not
change the terminal settings.

Also adjust the reference to isatty in the Illumos source.
@tklauser tklauser force-pushed the fix-solaris-isterminal branch from e9b6183 to 518b0c1 Compare May 26, 2021
@mattn
Copy link
Owner

@mattn mattn commented May 26, 2021

Right.

@mattn mattn merged commit 8b0c6d8 into mattn:master May 26, 2021
3 checks passed
@mattn
Copy link
Owner

@mattn mattn commented May 26, 2021

Thank you

@tklauser tklauser deleted the fix-solaris-isterminal branch May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants