Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.sum after golang.org/x/sys update #68

Merged
merged 1 commit into from Nov 21, 2021

Conversation

tklauser
Copy link
Contributor

PR #66 updated the golang.org/x/sys dependency in go.mod but didn't
update go.sum. This leads to the following error on running go.test.sh:

go: golang.org/x/sys@v0.0.0-20210630005230-0f9fa26af87c: missing go.sum entry; to add it:
	go mod download golang.org/x/sys
go: golang.org/x/sys@v0.0.0-20210630005230-0f9fa26af87c: missing go.sum entry; to add it:
	go mod download golang.org/x/sys

Fix this by running go mod download golang.org/x/sys && go mod tidy to
update and clean up go.sum.

@codecov-commenter
Copy link

Codecov Report

Merging #68 (bed7165) into master (d423e9c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   44.00%   44.00%           
=======================================
  Files           3        3           
  Lines          75       75           
=======================================
  Hits           33       33           
  Misses         40       40           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d423e9c...bed7165. Read the comment docs.

@tklauser
Copy link
Contributor Author

tklauser commented Oct 4, 2021

@mattn could you please take a look?

@mattn
Copy link
Owner

mattn commented Oct 5, 2021

Once go get -u again please.

PR mattn#66 updated the golang.org/x/sys dependency in go.mod but didn't
update go.sum. This leads to the following error on running go.test.sh:

    go: golang.org/x/sys@v0.0.0-20210630005230-0f9fa26af87c: missing go.sum entry; to add it:
    	go mod download golang.org/x/sys
    go: golang.org/x/sys@v0.0.0-20210630005230-0f9fa26af87c: missing go.sum entry; to add it:
    	go mod download golang.org/x/sys

Fix this by running go get -u && go mod tidy to update golang.org/x/sys
and clean up go.sum.
@tklauser
Copy link
Contributor Author

tklauser commented Oct 5, 2021

Once go get -u again please.

Done and force pushed.

@tklauser
Copy link
Contributor Author

tklauser commented Nov 2, 2021

@mattn friendly ping

@mattn mattn merged commit cdb00f1 into mattn:master Nov 21, 2021
@mattn
Copy link
Owner

mattn commented Nov 21, 2021

Thank you

@tklauser tklauser deleted the fix-go.sum branch Nov 21, 2021
guonaihong added a commit to guonaihong/gout that referenced this pull request Jan 2, 2022
在mac电脑上使用go1.17 以及sys库会导致runtime SIGSEGV
gout 会使用go-isatty判断终端, 该库直接依赖sys库, 导致gout间接依赖sys库

mattn/go-isatty#68

所以更新下
guonaihong added a commit to guonaihong/gout that referenced this pull request Jan 2, 2022
在mac电脑上使用go1.17 以及sys库会导致runtime SIGSEGV
gout 会使用go-isatty判断终端, 该库直接依赖sys库, 导致gout间接依赖sys库

mattn/go-isatty#68

所以更新下
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants