New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go Modules #26

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
3 participants
@SamWhited
Copy link
Contributor

SamWhited commented Dec 17, 2018

Hello,

Please consider supporting Go Modules, the new packaging standard that will be adopted fully in Go 1.12. Experimental support is in Go 1.11 and the new module paths are supported in Go 1.9.7+ and Go 1.10.3+ in a read-only manner for backwards compatibility with all supported versions of Go (although the import path doesn't change with this library, so it doesn't matter much here).

Because this library has no external dependencies, is still below version 2, and is already tagging its releases using semver compatible tags, not much changes in the library itself except to declare the canonical import path and the language being used in a go.mod file.
I picked Go 1.9 as the language being used because running tests with 1.9 appeared to work, and that's the earliest version that has some basic support for modules backported into it. Since only things using modules will read this file (and everything else will work exactly as it always had), that seemed like a safe bet for maximum compatibility. If you only support some higher version of Go and want to use features or APIs in a higher version this can be changed easily, of course.

Thank you for your consideration.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 17, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling b07c873 on SamWhited:support_modules into 3ee7d81 on mattn:master.

@mattn mattn merged commit 703b5e6 into mattn:master Dec 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@mattn

This comment has been minimized.

Copy link
Owner

mattn commented Dec 18, 2018

Thank you

@SamWhited SamWhited deleted the SamWhited:support_modules branch Dec 18, 2018

@SamWhited

This comment has been minimized.

Copy link
Contributor Author

SamWhited commented Dec 18, 2018

Sure thing; thanks for the merge. If you're not planning on making any changes soon, please consider tagging a new release with just this go.mod file in it; this will allow Go Module users to go ahead and pin to specific semver version that has the go.mod file instead of using the v0.0.0_date_commit magic version format.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment