too many open files after d56eb93 #131

Closed
fiber opened this Issue Jul 15, 2014 · 1 comment

Comments

Projects
None yet
1 participant

fiber commented Jul 15, 2014

commit d56eb93

  • in (SQliteConn) Query() a SQliteStmt is Prepared which opens a file,
  • however (SQliteRows) Close() calls sqlite3_reset(), not sqlite3_close_v2()
  • (SQliteConn) Exec() does also not close the Prepared statement

this code runs out of files:
https://gist.github.com/fiber/e096b0eca9d231740185

@fiber fiber pushed a commit to fiber/go-sqlite3 that referenced this issue Jul 15, 2014

Sven Engelhardt implicitly close Stmt in Queryer, Close #131 9dca08b

@fiber fiber pushed a commit to fiber/go-sqlite3 that referenced this issue Jul 15, 2014

Sven Engelhardt implicitly close Stmt in Queryer, Close #131
the cls field tracks if the Stmt should be implicitly closed, in the
Exec() call the generated statement is always closed
deaffef

fiber commented Jul 15, 2014

pull request #132 sent

mattn closed this in #132 Jul 16, 2014

@mattn mattn added a commit that referenced this issue Jul 16, 2014

@mattn mattn Merge pull request #132 from fiber/master
implicitly close Stmt in Queryer, Close #131
3db806a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment