MD5 gemified #1

Merged
merged 1 commit into from Dec 7, 2012

Projects

None yet

2 participants

@bovi
Contributor
bovi commented Dec 7, 2012

As promised (mruby/mruby#479) here a first pull request for a gemification. I actually found an interesting flaw in the current mrbgems implementation. A dash "-" in the GEM Name can't be handled. So when you want to use this GEM you have to change the directory name of this GEM from mruby-md5 to mruby_md5.

I will fix this issue in mrbgems as soon as possible. Shouldn't be hard.

@bovi bovi referenced this pull request in mruby/mruby Dec 7, 2012
Merged

mrbgems #479

@mattn mattn merged commit bb7b445 into mattn:master Dec 7, 2012
@mattn
Owner
mattn commented Dec 7, 2012

Thank you. I'll check it.

@mattn
Owner
mattn commented Dec 7, 2012

I added full-path of mrb-mruby_md5-gem.a into GEMS.active and type make

C:/temp/github/mruby/mrbgems/generator.exe makefile_list "GEMS.active" > g/MakefileGemList
Generate Gem Makefile
C:/temp/github/mruby/mrbgems/generator.exe makefile "GEMS.active" > g/Makefile
Build all gems
mingw32-make -C g MRUBY_ROOT='C:/temp/github/mruby' ACTIVE_GEMS="GEMS.active"
mingw32-make: *** c:/temp/github/mruby-md5/mrb-mruby_md5-gem.a: Invalid argument.
Makefile:19: recipe for target 'all_gems' failed
mingw32-make[2]: *** [all_gems] Error 2
Makefile:42: recipe for target 'all_gems' failed
mingw32-make[1]: *** [all_gems] Error 2
Makefile:57: recipe for target 'all' failed
mingw32-make: *** [all] Error 2
@bovi
Contributor
bovi commented Dec 7, 2012

Oh sorry. I was probably unclear. Two things have to be different:

  • you have to rename your directory from c:/temp/github/mruby-md5/ to c:/temp/github/mruby_md5/
  • you have to only add the path to your GEM directory, not the archive file. In your case add c:/temp/github/mruby_md5/ to the GEMS.active

The renaming issue I will fix with a new patch to mrbgems.

@mattn
Owner
mattn commented Dec 7, 2012

Oops Sorry, it's time to finish of hack today. I'll look into it in next time.
Thank you!

On 12/7/12, Daniel Bovensiepen notifications@github.com wrote:

Oh sorry. I was probably unclear. Two things have to be different:

  • you have to rename your directory from c:/temp/github/mruby-md5/ to

`````` c:/temp/github/mruby_md5/```

  • you have to only add the path to your GEM directory, not the archive file.
    In your case add c:/temp/github/mruby_md5/ to the GEMS.active

The renaming issue I will fix with a new patch to mrbgems.


Reply to this email directly or view it on GitHub:
#1 (comment)

  • Yasuhiro Matsumoto
@bovi
Contributor
bovi commented Dec 8, 2012

Ok the patch is in the main branch. Now you don't need to rename your GEM anymore. Tell me if everything works out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment