Perl's VC Makefile has -nodefaultlib in LINK_FLAGS#16
Merged
mattn merged 1 commit intomattn:masterfrom Feb 19, 2016
Merged
Conversation
This means `$Config{ldflags}` also ends up including that. Therefore,
`assert_lib` fails to build executables. E.g. see this [test report][1].
This patch fixes the test failures, as well as failures in normal use to
verify existence of correctly installed libraries, by adding the
libraries specified in `$Config{libs}`.
[1]:
http://www.cpantesters.org/cpan/report/6b5e2c37-6c63-1014-a1df-a81897e06df3
mattn
added a commit
that referenced
this pull request
Feb 19, 2016
Perl's VC Makefile has -nodefaultlib in LINK_FLAGS
Owner
|
Thanks! |
Contributor
Author
|
Thank you very much for your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means
$Config{ldflags}also ends up including that. Therefore,assert_libfails to build executables. E.g. see this test report.This patch fixes the test failures, as well as failures in normal use to verify existence of correctly installed libraries, by adding the libraries specified in
$Config{libs}.I am not sure if this is the best way to handle the situation, but it seems to work.