Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perl's VC Makefile has -nodefaultlib in LINK_FLAGS #16

Merged
merged 1 commit into from Feb 19, 2016

Conversation

@nanis
Copy link
Contributor

@nanis nanis commented Feb 19, 2016

This means $Config{ldflags} also ends up including that. Therefore, assert_lib fails to build executables. E.g. see this test report.

This patch fixes the test failures, as well as failures in normal use to verify existence of correctly installed libraries, by adding the libraries specified in $Config{libs}.

I am not sure if this is the best way to handle the situation, but it seems to work.

This means `$Config{ldflags}` also ends up including that. Therefore,
`assert_lib` fails to build executables. E.g. see this [test report][1].

This patch fixes the test failures, as well as failures in normal use to
verify existence of correctly installed libraries, by adding the
libraries specified in `$Config{libs}`.

[1]:
http://www.cpantesters.org/cpan/report/6b5e2c37-6c63-1014-a1df-a81897e06df3
mattn added a commit that referenced this pull request Feb 19, 2016
Perl's VC Makefile has -nodefaultlib in LINK_FLAGS
@mattn mattn merged commit c0c59df into mattn:master Feb 19, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mattn
Copy link
Owner

@mattn mattn commented Feb 19, 2016

Thanks!

@nanis
Copy link
Contributor Author

@nanis nanis commented Feb 19, 2016

Thank you very much for your work.

C:\...\> cpanm https://github.com/mattn/p5-Devel-CheckLib.git 
Cloning https://github.com/mattn/p5-Devel-CheckLib.git ... OK                              
--> Working on https://github.com/mattn/p5-Devel-CheckLib.git                              
Configuring C:\...\RgGciVnKkw ... OK                            
Building and testing Devel-CheckLib-1.05 ... OK                                            
Successfully installed Devel-CheckLib-1.05                                                 
1 distribution installed                                                                   
@nanis nanis deleted the nanis:nanis-windows-vc-fix branch Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.