Skip to content

Conversation

@Cj-bc
Copy link
Contributor

@Cj-bc Cj-bc commented Nov 12, 2018

記事を書く際に、tagを指定することができるようになりました。
タグは2行目に、空白文字 区切りで記載します。
バージョン情報がある場合は、Qiitaでのものと同じく、<tag名>:<version>という表記になります。

https://asciinema.org/a/211390

Cj-bc added 12 commits October 20, 2018 11:13
Because 'tag' seems to be conflict with vim command
Because I couldn't make good regex which support `[]`
I think this is caused because I use `[]` as the IFS of each tag.
I finally notice that qiita's tag can't contain ' '!!
Why don't we use it as separator
So that we don't have to parse '[]'.(that was difficult for me) ;)
Tag object is in arg?
        |--- yes -----> set it as tag
     no |
        V
Is `filetype` set?
        |--- yes -----> set it as tag
     no |
        V
    set 'text' as tag
To specify version, please follow the format:
<tag_name>:<version>
@Cj-bc
Copy link
Contributor Author

Cj-bc commented Nov 12, 2018

修正しました。
とても早い対応ありがとうございます...!!

@mattn
Copy link
Owner

mattn commented Nov 12, 2018

あとコンフリクトしている様です。

@Cj-bc
Copy link
Contributor Author

Cj-bc commented Nov 12, 2018

コンフリクト解消しました

@mattn mattn merged commit 8c75e88 into mattn:master Nov 13, 2018
@mattn
Copy link
Owner

mattn commented Nov 13, 2018

Thank you

@Cj-bc Cj-bc deleted the feature/tag-support branch November 13, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants