-
-
Notifications
You must be signed in to change notification settings - Fork 7
feature: tag付対応 #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because 'tag' seems to be conflict with vim command
Because I couldn't make good regex which support `[]` I think this is caused because I use `[]` as the IFS of each tag.
I finally notice that qiita's tag can't contain ' '!! Why don't we use it as separator So that we don't have to parse '[]'.(that was difficult for me) ;)
Tag object is in arg?
|--- yes -----> set it as tag
no |
V
Is `filetype` set?
|--- yes -----> set it as tag
no |
V
set 'text' as tag
To specify version, please follow the format: <tag_name>:<version>
mattn
reviewed
Nov 12, 2018
mattn
reviewed
Nov 12, 2018
mattn
reviewed
Nov 12, 2018
mattn
reviewed
Nov 12, 2018
Contributor
Author
|
修正しました。 |
mattn
reviewed
Nov 12, 2018
Owner
|
あとコンフリクトしている様です。 |
Contributor
Author
|
コンフリクト解消しました |
Owner
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
記事を書く際に、tagを指定することができるようになりました。
タグは2行目に、空白文字
区切りで記載します。バージョン情報がある場合は、Qiitaでのものと同じく、
<tag名>:<version>という表記になります。https://asciinema.org/a/211390