implement list

[little-dude]

cf: #10

This is work in progress. I need to add nlst as well. But if you have feedback aleady it's great. Maybe I should rename list() to ls(), also.

[matt2xu]

It looks fine. The code will be a bit simpler once I take the time to make a pull request for error handling :-)
Also, I don't think you need to explicitly drop the connection, I believe the stream will be automatically dropped when it goes out of scope if I understand correctly.

Suggestion: maybe parse the list that is returned, so you get a Vec for instance, rather than a String?

[little-dude]

thanks for the feedback!

The code will be a bit simpler once I take the time to make a pull request for error handling

Yes, please! :D

I don't think you need to explicitly drop the connection

👍

maybe parse the list that is returned, so you get a Vec for instance, rather than a String?

👍

[mattnenterprise]

@little-dude Can you resolve the conflicts.

[little-dude]

@mattnenterprise I'll probably wait for #21, unless you want to merge this first.

[mattnenterprise]

@little-dude #21 has been merged

[matt2xu]

@little-dude if you want to see this PR merged, you need to update it so it can be merged. To do that, rebase it on top of upstream/master. I doubt you'll have conflicts, so this should go smoothly :-) Then push your changes (forcefully with the -f option) on your list2 branch.

[little-dude]

seems that this has been done already. not need to keep this pr open.