Allow the retr reader to return something other than unit #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed the same change is implemented in #59 ! I'm happy to wait for that & close this but I'll leave this open for you to decide. |
|
Closing this as I added an unrelated commit which is not backward compatible |
|
cc @mattnenterprise can you merge #59 please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny change but as a Rust newbie I found it was easier to return resources I created in a closure processing the FTP stream than it was to create resources outside & have to thread mutable references through various scopes.
I am assuming this will be totally backwards compatible thanks to type inference but let me know if I'm mistaken.