New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rails 5 #24

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@st0012
Copy link

st0012 commented Dec 22, 2016

No description provided.

@st0012

This comment has been minimized.

Copy link
Author

st0012 commented Dec 22, 2016

This should solve #23

@@ -42,7 +42,7 @@ def call(env)
headers['Content-Type'] = Rack::Mime.mime_type(File.extname(path), 'text/plain')

# Update cache-control to add directive telling Rack::Deflate to leave it alone.
cache_control = headers['Cache-Control'].try(:to_s).try(:downcase)
cache_control = headers['Cache-Control']&.to_s&.downcase

This comment has been minimized.

@dcosson

dcosson Dec 31, 2016

I'm not a maintainer or anything but would love to see this merged as I'm working on migrating a codebase to rails 5 that uses it.

I'm pretty sure this use of try still works fine in rails 5 though, so this change doesn't seem necessary and it would break support for ruby < 2.3

This comment has been minimized.

@itkin
@david-a-wheeler

This comment has been minimized.

Copy link

david-a-wheeler commented Jan 4, 2017

Please do fix the Rails 5 incompatibility.

This problem has been noted elsewhere:
http://stackoverflow.com/questions/39549962/rake-assetsprecompile-failed-when-push-rails5-app-to-heroku/39550697#39550697

On a project I'm on we've had to drop using heroku_rails_deflate because we're transitioning to Rails 5:
coreinfrastructure/best-practices-badge#556

@digerata

This comment has been minimized.

Copy link

digerata commented Feb 9, 2017

Curious, is there anything hold up this PR?

@digerata digerata referenced this pull request Feb 9, 2017

Open

Support rails 5 v2 #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment