Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve button accessibility #207

Merged
merged 2 commits into from
Jun 7, 2017
Merged

Improve button accessibility #207

merged 2 commits into from
Jun 7, 2017

Conversation

mattrubin
Copy link
Owner

@mattrubin mattrubin commented Jun 7, 2017

Add accessibility labels and hints to custom buttons. Closes #190.

There are further accessibility refinements that can be made, but these changes begin by making all elements in the app compatible with VoiceOver.

@mattrubin mattrubin added this to the 2.0 milestone Jun 7, 2017
@codecov
Copy link

codecov bot commented Jun 7, 2017

Codecov Report

Merging #207 into develop will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #207      +/-   ##
===========================================
+ Coverage    37.72%   37.78%   +0.05%     
===========================================
  Files           36       36              
  Lines         2139     2141       +2     
===========================================
+ Hits           807      809       +2     
  Misses        1332     1332
Impacted Files Coverage Δ
...henticator/Source/TokenScannerViewController.swift 0% <ø> (ø) ⬆️
Authenticator/Source/TokenListViewController.swift 64.9% <ø> (ø) ⬆️
Authenticator/Source/TokenRowCell.swift 85.71% <100%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f72c1a...f68d0c0. Read the comment docs.

@mattrubin mattrubin merged commit 81ff489 into develop Jun 7, 2017
@mattrubin mattrubin deleted the accessibility branch June 7, 2017 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant