Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
It doesn't work on Windows #46
OK, title is a bit provocative, I should add "out of the box"...
First, thanks for the plugin: we use Perforce at work, and hand-checking out these pesky read-only files would be a pain... I used Brackets previously, it has a similar plugin (but more primitive), it is very useful (although intermittently failing, probably because P4 doesn't answer fast enough).
I use Atom 1.3.1 on Win7.
I pasted the above path (without p4.exe), but it still doesn't work.
Looked at console, found the following:
Note: the file IS in a Perforce workspace, of course.
Atom shows the following message when I save with auto-edit activated:
OK, I will take a look at the source code, but I promise nothing: I am not a Node.js dev, neither an Atom one!
OK, found an issue, line 169 of atom-perforce.js
The paths should be normalized at some point (and you should pull out this test to its own function, I see it in all commands...).
I made some changes to see if I can make it to work... At least, it was interesting to see I can easily hack and debug an Atom package...
I can confirm it works after normailizing the slashes. I still see an error at start on
Well, this style of path works in Windows in 99 % of cases, so it is safer to rely on it...
Would work on my computer, as I installed Unix utilities (UnxUtils or GnuWin32), but it won't work, AFAIK, on most Windows computers.
Note: after my hack, the package works with p4 in the path (ie. I removed the path from the settings), so just keep the current behavior as is (just fix these pseudo escape keys in the string!
Oh, didn't know
Errors on startup: I get them on the
Note: I also suggest to avoid doing a
OK, i no longer have errors in the console, and I can check out files.
Just take inspiration from these changes, perhaps, improve them (they are a bit hasty, etc.). Feel free to use at will.