TTTUnitOfInformationFormatter: Support bigger numbers #34

Merged
merged 3 commits into from Mar 8, 2013

Conversation

Projects
None yet
3 participants

Fixes a problem when getting a string from a big number because of casting the result of a multiplication to integer.

Owner

mattt commented Mar 4, 2013

Thanks for the patch, @brutella.

Would e83d1f4 work the same if we used numberWithLongLong: instead of numberWithDouble:?

brutella commented Mar 8, 2013

I thought about that too. It still works with long long.

mattt added a commit that referenced this pull request Mar 8, 2013

Merge pull request #34 from brutella/fix-bigger-numbers
TTTUnitOfInformationFormatter: Support bigger numbers

@mattt mattt merged commit 076d090 into mattt:master Mar 8, 2013

Owner

mattt commented Mar 8, 2013

Great. Yeah, long long makes more sense for integer values. Thanks, @brutella.

Use long long here is incorrect.
result will lose precision.

should revert this line.

@brutella brutella deleted the brutella:fix-bigger-numbers branch Oct 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment