about @[ @"A", @"B" ] #2

Closed
fjun99 opened this Issue Sep 6, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@fjun99

fjun99 commented Sep 6, 2012

Thank first. I am already using SkyLab and GroundControl.

It makes life easy to init a array or dictionary using @[] or @{}. But it will be a problem for those whose XCode is still under 4.2. I encountered this problem.

In the code you init a array using this:

@[ @"A", @"B" ]

would you please change it to [NSArray arrayWithObjects:@"A", @"B", nil]?

mattt added a commit that referenced this issue Sep 6, 2012

@mattt

This comment has been minimized.

Show comment
Hide comment
@mattt

mattt Sep 6, 2012

Owner

You know, you have a good point here. While object literals make this a heckuva better-looking in the README, there's no really good reason for me to force object literals in the private implementation, if it's going to cause so much hassle for so little benefit. I've changed this in 487ae74.

While the example project won't work on older versions of Xcode, you'll be able to use SkyLab just fine on its own. Thanks for bringing this to my attention.

Owner

mattt commented Sep 6, 2012

You know, you have a good point here. While object literals make this a heckuva better-looking in the README, there's no really good reason for me to force object literals in the private implementation, if it's going to cause so much hassle for so little benefit. I've changed this in 487ae74.

While the example project won't work on older versions of Xcode, you'll be able to use SkyLab just fine on its own. Thanks for bringing this to my attention.

@mattt mattt closed this Sep 6, 2012

@fjun99

This comment has been minimized.

Show comment
Hide comment
@fjun99

fjun99 Sep 6, 2012

Thank you. I guess there is no need to change the example project.

On Thu, Sep 6, 2012 at 10:32 AM, Mattt Thompson notifications@github.comwrote:

You know, you have a good point here. While object literals make this a
heckuva better-looking in the README, there's no really good reason for me
to force object literals in the private implementation, if it's going to
cause so much hassle for so little benefit. I've changed this in 487ae74487ae74
.

While the example project won't work on older versions of Xcode, you'll be
able to use SkyLab just fine on its own. Thanks for bringing this to my
attention.


Reply to this email directly or view it on GitHubhttps://github.com/mattt/SkyLab/issues/2#issuecomment-8320563.

fjun99 commented Sep 6, 2012

Thank you. I guess there is no need to change the example project.

On Thu, Sep 6, 2012 at 10:32 AM, Mattt Thompson notifications@github.comwrote:

You know, you have a good point here. While object literals make this a
heckuva better-looking in the README, there's no really good reason for me
to force object literals in the private implementation, if it's going to
cause so much hassle for so little benefit. I've changed this in 487ae74487ae74
.

While the example project won't work on older versions of Xcode, you'll be
able to use SkyLab just fine on its own. Thanks for bringing this to my
attention.


Reply to this email directly or view it on GitHubhttps://github.com/mattt/SkyLab/issues/2#issuecomment-8320563.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment