New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go Modules #15

Merged
merged 1 commit into from Dec 31, 2018

Conversation

Projects
None yet
2 participants
@SamWhited
Copy link
Contributor

SamWhited commented Dec 22, 2018

Hello,

Please consider supporting Go Modules, the new packaging standard that will be adopted fully in Go 1.12. Experimental support is in Go 1.11 and the new module paths are supported in Go 1.9.7+ and Go 1.10.3+ in a read-only manner for backwards compatibility with all supported versions of Go.

Because this library is still below version 2, already uses semver compatible tags, and has few dependencies, the go.mod file is fairly simple.

Note that I set the language version go 1.9 in the mod file because 1.9.7 is the earliest version with partial support for reading the go.mod file (earlier versions will keep working as they always have and won't read the go.mod file). I also took the liberty of bumping the versions you test against in Travis to include more recent versions, and the most recent patch release of each version. I wasn't sure what the earliest syntax and APIs you actually wanted to support was, so I just picked 1.9 (although I think 1.10 is the earliest version still supported by the Go team). Let me know if this was wrong or you'd like it changed.

Thank you for your consideration.

Show resolved Hide resolved go.mod
@matttproud

This comment has been minimized.

Copy link
Owner

matttproud commented Dec 31, 2018

This generally looks fine. Thank you for taking the time to do this.

@matttproud matttproud merged commit c182aff into matttproud:master Dec 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SamWhited SamWhited deleted the SamWhited:support_modules branch Jan 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment