Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add support for custom headers #22

Merged
merged 1 commit into from Sep 27, 2012

Conversation

Projects
None yet
2 participants
Contributor

rslinckx commented Sep 27, 2012

headers can be passed as a dict to the message constructor and are passed as-is to the underlying lamson mail.

Contributor

rslinckx commented Sep 27, 2012

This is related to #11

Owner

mattupstate commented Sep 27, 2012

Semantically, I'm not sure the parameter name headers is appropriate for this functionality. Basically, everything is a header. So maybe rename it to extra_headers or custom_headers so there API is, arguably, clear. I'm leaning towards extra_headers. Also, if you could just add a test that verifies this works.

@rslinckx rslinckx Support extra_headers argument to Message to include custom email hea…
…ders

Anything found in extra_headers is passed as-is to the underlying lamson message.
It will also override anything previously set by flask-mail.
035f4d3
Contributor

rslinckx commented Sep 27, 2012

This should do the trick then..

@mattupstate mattupstate added a commit that referenced this pull request Sep 27, 2012

@mattupstate mattupstate Merge pull request #22 from rslinckx/patch-1
Add support for custom headers
bcd4de4

@mattupstate mattupstate merged commit bcd4de4 into mattupstate:master Sep 27, 2012

Owner

mattupstate commented Sep 27, 2012

Brilliant. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment