catch possible TypeError and ValueError from serializer #205

Merged
merged 4 commits into from Jan 24, 2014

Projects

None yet

2 participants

@jamesonjlee
Contributor

see issue #204

@mattupstate
Owner

When is this possible?

@jamesonjlee
Contributor

Certain users could request for a reset password url (the resulting url was customized via config) and the resulting URL could cause the server to return a 503 due to TypeError exception being bubbled up from itsdangerous.

since the patch I now get a proper 200 with error message instead of the trace. I was able to reproduce the error on safari, chrome and ie9.

@mattupstate
Owner

Could you please write a test case for your situation?

@jamesonjlee
Contributor

I will look into producing the test case (it's basically a mangled urlencode string)

@jamesonjlee
Contributor

@mattupstate I produced the test, fails because python 3.3

@mattupstate
Owner

Thanks!

@mattupstate mattupstate merged commit f854c24 into mattupstate:develop Jan 24, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment