Make logout view do nothing if the user is already logged out #217

Merged
merged 1 commit into from Feb 4, 2014

Conversation

Projects
None yet
3 participants
Contributor

swarmer commented Feb 4, 2014

Currently if the user visits /logout while not being logged in, they will be redirected to /login and after successful authentication immediately logged out again. That doesn't make a lot of sense and can be pretty confusing. Apparently this can even happen if the user is logged in: as soon as you type /logout into address bar in Chrome it does a "prerender" request and when you press enter it may request /logout again (no idea why).

I made logout view simply redirect to SECURITY_POST_LOGOUT_VIEW if the user is already logged out.

Coverage Status

Coverage increased (+0.13%) when pulling 09f6f64 on swarmer:logout-fix into 8e8d581 on mattupstate:develop.

Coverage Status

Coverage increased (+0.13%) when pulling 09f6f64 on swarmer:logout-fix into 8e8d581 on mattupstate:develop.

Owner

mattupstate commented Feb 4, 2014

Thanks for catching this little snafu.

mattupstate added a commit that referenced this pull request Feb 4, 2014

Merge pull request #217 from swarmer/logout-fix
Make logout view do nothing if the user is already logged out

@mattupstate mattupstate merged commit 0268a2d into mattupstate:develop Feb 4, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment