Matt Wildig mattwildig

  • Joined on

Organizations

@haml
mattwildig commented on issue haml/haml#845
@mattwildig

All the lines need to have the |, including the last one. Your code should work if you add it to the final line of the condition: - if condition_1 …

mattwildig commented on issue haml/haml#842
@mattwildig

Somewhat related: I think we may need to look at how separating Action View into its own gem affects us. There are a couple of places we check Acti…

mattwildig commented on issue haml/haml#842
@mattwildig

I think I’ve tracked this down. Rails 4.2 uses rails-html-sanitizer, which defines the Rails module (it is required in saintize_helper, which gets …

mattwildig commented on issue haml/haml#842
@mattwildig

How are you trying to use Haml here? If you’re not using Rails you can just use Haml by itself (require 'haml'), no need for haml/template or actio…

@mattwildig
mattwildig closed issue haml/haml#838
@mattwildig
HAML parser doesn't include full comment text in block comments
mattwildig commented on issue haml/haml#838
@mattwildig

I’ve fixed this in b09e458, but the fix is really a side effect of the work there. This is really an internal detail, I don’t think we can guarante…

mattwildig commented on commit haml/haml@5163269eb2
@mattwildig

Oops. Yes, thanks.

mattwildig pushed to master at haml/haml
@mattwildig
  • @mattwildig b09e458
    Unify filter and haml_comment parsing
mattwildig closed issue haml/haml#840
@mattwildig
Haml Comments: -# Inconsistent indentation
mattwildig commented on issue haml/haml#840
@mattwildig

You’re right, this looks like a bug (see also #464). It looks like indents within comments are being ignored as long as they are a multiple of the …

mattwildig commented on issue haml/haml#839
@mattwildig

I think this is the same as #648. My feeling is they should both behave as the second one (without the script).

@mattwildig
mattwildig closed pull request haml/haml-spec#11
@mattwildig
Use Minitest::Test if it is available
mattwildig commented on pull request haml/haml-spec#11
@mattwildig

Hadn’t noticed @amatsuda had beaten me to this in #10.

mattwildig commented on issue haml/haml#837
@mattwildig

You have a typo in your seeds.rb file. Also, in order to get the same error you’re seeing you need to have therubyracer in the Gemfile (jsc just ha…

@mattwildig
mattwildig commented on issue haml/haml#837
@mattwildig

The ugly option will only affect the HTML generated by HAML – it won’t do anything to the contents of filters. Where is the error coming from – is …

mattwildig commented on issue haml/haml#836
@mattwildig

I don’t think you can do this solely in the method, but you could use the :plain filter: = highlight(lang: 'haml') do :plain %h1 test and then use c…

mattwildig commented on issue haml/haml#835
@mattwildig

The HTML spec says this about data attributes: A custom data attribute is an attribute in no namespace whose name starts with the string "data-", …

mattwildig commented on issue haml/haml#832
@mattwildig

It’s not intentional as such, it’s a limitation of the parser when detecting interpolated sections. It’s fairly simple and expects braces to be in …

mattwildig pushed to master at haml/haml
@mattwildig
mattwildig commented on issue haml/haml#830
@mattwildig

Thanks for reporting this. I’ve pushed a fix, so you should be ok in the next release. Note that in this case the pipe character isn’t needed, sinc…

mattwildig pushed to master at haml/haml
@mattwildig
  • @mattwildig 85e6592
    Only use parsed value when checking Ruby multiline
mattwildig closed issue haml/haml#830
@mattwildig
4.1.0.beta.1 > Illegal nesting with Multiline |
mattwildig commented on pull request sinatra/sinatra#965
@mattwildig

I’ve just has a look at this out of curiosity, and it seems like this warning has been removed from MRI Ruby: https://bugs.ruby-lang.org/issues/10661