New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use strict #2

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dginev

dginev commented Jan 2, 2015

No description provided.

@mauke

This comment has been minimized.

Show comment
Hide comment
@mauke

mauke Jan 2, 2015

Owner
  1. That patch is incomplete. You'd have to add strict to the module dependencies in Makefile.PL.
  2. use v5.12 automatically enables strict mode, so this is redundant.
Owner

mauke commented Jan 2, 2015

  1. That patch is incomplete. You'd have to add strict to the module dependencies in Makefile.PL.
  2. use v5.12 automatically enables strict mode, so this is redundant.

@mauke mauke closed this Jan 2, 2015

@dginev

This comment has been minimized.

Show comment
Hide comment
@dginev

dginev Jan 2, 2015

Interesting, I wasn't aware that 5.12 enforces strict automatically, that's quite nice.

Also curious that you are saying one of the most central core modules should also be added to the Makefile dependencies, but I see the point, even if it seems overly explicit in my eyes.

Thanks for the feedback!

dginev commented Jan 2, 2015

Interesting, I wasn't aware that 5.12 enforces strict automatically, that's quite nice.

Also curious that you are saying one of the most central core modules should also be added to the Makefile dependencies, but I see the point, even if it seems overly explicit in my eyes.

Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment