Relax checks for extended capability to support new format #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the 20180331 release, the format was slightly changed: > 20180331 > + improve terminfo write/read by modifying the fourth item of the > extended header to denote the number of valid strings in the extended > string table (prompted by a comment in unibilium's sources). Since the number of valid string capabilities is not necessarily the same as extstrslen, it's not possible to sanity check the total number of items up front anymore. Include a new test with an updated screen terminfo dump.
|
This only addresses the parser path, not |
|
FYI, I'm carrying this patch in Debian's unibilium packaging, as the inability to parse the new format was affecting neovim's input handling. |
|
For reference: neovim#5 - I've done it there based on the patch carried in Neovim. |
|
Merged in https://github.com/neovim/unibilium. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 20180331 release, the format was slightly changed:
Since the number of valid string capabilities is not necessarily the
same as extstrslen, it's not possible to sanity check the total number
of items up front anymore.
Include a new test with an updated screen terminfo dump.