Issue 83: Support for multi core using ServiceLocator#5
Closed
paulbouwer wants to merge 3 commits into
Closed
Conversation
Member
|
Nice! But the commit shows up as a complete modification of all involved files, so it makes reviewing it nearly impossible. It seems to be an issue with autocrlf settings in git. Can you try setting core.autocrlf to true and re-committing? Thanks |
Author
|
I've only just started using Git and still getting up to speed on it - how would I go about doing this. I ran the following commands:
The commit still shows complete modification of all involved files. I obtained a raw copy of your version of one of the files I committed and it seems to only have LF line endings (https://github.com/mausch/SolrNet/raw/master/SolrNet/Utils/Container.cs). My files have CRLF. Should I change my files to LF only and recommit ? Thanks |
Member
|
Applied in 94505a6, thanks! |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Mauricio
I've implemented this feature to support a multi-tenancy requirement. I have added new tests and updated some existing tests. All pass. The following is an example of how to use it.
Startup.InitCore<TestDocument>("core1", "http://localhost");
Startup.InitCore<TestDocument>("core2", "http://localhost");
var solrOperations1 = ServiceLocator.Current.GetInstance<ISolrOperations<TestDocument>>("core1");
var solrOperations2 = ServiceLocator.Current.GetInstance<ISolrOperations<TestDocument>>("core2");
You can still use the existing Init method without cores:
Startup.Init<TestDocument>("http://localhost");
var solrOperations = ServiceLocator.Current.GetInstance<ISolrOperations<TestDocument>>();
Hope it helps.
Paul