New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activeLink is not set for Focus Items plugin - no active page indicator #2788

Closed
MarkLL opened this Issue Oct 19, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@MarkLL
Contributor

MarkLL commented Oct 19, 2016

What type of report is this:

Q A
Bug report? Y
Feature request? N
Enhancement? N

Description:

Focus Items active page indicator does not appear on the menu sidebar. yes I mean the little yellow dot that indicates which of the sub-menus is currently active.

I realize it's a little cosmetic bug, but I find bugs for a living so I'm a bit picky in some cases.

The good news was -- as I'm new to Mautic -- it allowed me to figure out how the activeLink feature works and it's a really easy fix.

Simply change https://github.com/mautic/mautic/blob/staging/plugins/MauticFocusBundle/Controller/FocusController.php#L31

from null to '#mautic_focus_index'

Sorry, haven't been down the PR track so thought this would be the quickest way. I hope to contribute more as I become more familiar with Mautic's workings :)

If a bug:

Q A
Mautic version 2.2.0+
PHP version

Steps to reproduce:

  1. Login and extend the Channels side menu.
  2. Click on Emails and you will see the Active page indicator (the yellow dot)
  3. Now click on the Focus Items menu and you will see that the active page indicator does not show.

Log errors:

N/A

@FlamesRunner

This comment has been minimized.

Show comment
Hide comment
@FlamesRunner

FlamesRunner Oct 6, 2017

I'll take it.

FlamesRunner commented Oct 6, 2017

I'll take it.

@FlamesRunner

This comment has been minimized.

Show comment
Hide comment
@FlamesRunner

FlamesRunner Oct 6, 2017

Fixed in pull request #5108.

FlamesRunner commented Oct 6, 2017

Fixed in pull request #5108.

umeshgmrl added a commit to umeshgmrl/mautic that referenced this issue Oct 29, 2017

#2788
activeLink is not set for Focus Items plugin - no active page indicator

@dbhurley dbhurley closed this Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment