Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPROD-272: Dropped PluginConfiguration.php #11032

Merged
merged 3 commits into from Sep 23, 2022
Merged

TPROD-272: Dropped PluginConfiguration.php #11032

merged 3 commits into from Sep 23, 2022

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Apr 4, 2022 •
edited

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Steps to test this PR:

Fix https://mautic.atlassian.net/browse/TPROD-272
Blocked for Symfony 5. Seems like we do not use it anywhere

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Check If installation works like before and plugins reload works too

@kuzmany kuzmany added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Apr 4, 2022
@kuzmany kuzmany added this to the 5.0-alpha milestone Apr 4, 2022
@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Apr 4, 2022
@kuzmany kuzmany changed the title Dropped PluginConfiguration.php M5: Dropped PluginConfiguration.php Apr 4, 2022
@kuzmany kuzmany changed the title M5: Dropped PluginConfiguration.php TPROD-272: Dropped PluginConfiguration.php Apr 4, 2022
escopecz
escopecz previously approved these changes Apr 6, 2022
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I cannot find it used anywhere 👍

@escopecz escopecz added pending-test-confirmation PR's that require one test before they can be merged bc-break A BC break PR for major release milestones only and removed ready-to-test PR's that are ready to test labels Apr 6, 2022
@RCheesley
Copy link
Sponsor Member

Looks like some conflicts to be resolved, but may want to wait for the 4.x->4.x merge to be completed before we address them.

@RCheesley
Copy link
Sponsor Member

@kuzmany could you please resolve the conflicts in this PR? Thanks!

@escopecz escopecz self-assigned this Sep 14, 2022
@escopecz escopecz force-pushed the Dropped_support_for_constructing_a_TreeBuilder_without_passing_root_node_information branch from d6ff0f8 to b6cbfae Compare September 14, 2022 10:51
@escopecz
Copy link
Sponsor Member

I was not able to rebase, merge nor cherry-pick the last commit without resolving thousands of errors, so I created a new one with the same content.

Ready for second test/review.

mollux
mollux approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@mollux mollux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, looks good and indeed nowhere used

@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Sep 23, 2022
@escopecz escopecz merged commit fed44b2 into 5.x Sep 23, 2022
@escopecz escopecz deleted the Dropped_support_for_constructing_a_TreeBuilder_without_passing_root_node_information branch August 10, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollux mollux mollux approved these changes

@escopecz escopecz escopecz left review comments

Assignees

@escopecz escopecz

Labels
bc-break A BC break PR for major release milestones only bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Milestone
5.0-alpha
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kuzmany @RCheesley @escopecz @mollux