Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dynamic content button from default button list, add only to emails #2659

Merged
merged 1 commit into from Oct 11, 2016
Merged

Remove dynamic content button from default button list, add only to emails #2659

merged 1 commit into from Oct 11, 2016

Conversation

dongilbert
Copy link
Member

Q A
Bug fix? Y
New feature? N
Related user documentation PR URL N/A
Related developer documentation PR URL N/A
Issues addressed (#s or URLs) N/A
BC breaks? N/A
Deprecations? N/A

Description:

The Dynamic Content button shows in editors where it's not currently supported. This PR fixes that.

Steps to test this PR:

  1. Apply PR & run through steps to reproduce
  2. The button will be removed from the editor instead of being there.

Steps to reproduce the bug:

  1. Open the landing page editor
  2. On the right of the editor toolbar, you'll see the Dynamic Content button even though dc isn't supported within landing pages yet.

@dongilbert dongilbert added T1 Low difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test Hacktoberfest labels Oct 6, 2016
@dongilbert dongilbert added this to the 2.2.1 milestone Oct 6, 2016
@mqueme
Copy link
Contributor

mqueme commented Oct 11, 2016 •
edited by dbhurley

?? gone!

@mqueme mqueme added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Oct 11, 2016
@alanhartless alanhartless merged commit 3ec448c into mautic:staging Oct 11, 2016
@dongilbert dongilbert deleted the bugfix-dynamic-email-content branch April 6, 2017 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dongilbert @mqueme @alanhartless