Fix test failures #3167

Open
wants to merge 2 commits into
from

Projects

None yet

2 participants

@dongilbert
Member
Q A
Bug fix? Y
New feature? N
Related user documentation PR URL N/A
Related developer documentation PR URL N/A
Issues addressed (#s or URLs) N/A
BC breaks? N
Deprecations? N/A

Description:

This PR fixes the test failures that were introduced with the SAML SSO feature in 2.5. It adds required configuration parameters to the security_test.php

Steps to test this PR:

  1. Apply PR & clear cache
  2. Run phpunit from the app directory to see test failures are gone.

Steps to reproduce the bug:

  1. Be on 2.5 branch
  2. Run phpunit from the app directory, and see test failures due to InvalidConfigurationException: The child node "own" at path "light_saml_symfony_bridge" must be configured.
@dongilbert dongilbert requested a review from alanhartless Jan 3, 2017
@dongilbert dongilbert added this to the 2.6.0 milestone Jan 4, 2017
@escopecz
Contributor

unit tests are fixed with this PR applied 👍 Thanks Don!

@dongilbert
Member

@alanhartless Can we get this merged into staging so that all new PR's stop failing their Travis checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment