New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics UTM tags for emails and notifications #3891

Merged
merged 19 commits into from Jun 28, 2017

Conversation

@kuzmany
Contributor

kuzmany commented Apr 23, 2017

Q A
Bug fix?
New feature? y
Related user documentation PR URL n
Related developer documentation PR URL
Issues addressed (#s or URLs) #3516 #3106 #449
BC breaks?
Deprecations?

Description:

GA UTM tags support for emails and notifications (web & mobile).
Based on @alanhartless recommendations from this thread #3106 (comment)

Fund this feature https://mautic-fund.kuzmany.biz/campaign/1/google-analytics-utm-tags-for-channels

Steps to test this PR:

  1. Apply PR
  2. Call php app/console doctrine:schema:update -f
  3. Edit email and add utm params in Advanced tab
  4. Send email and see update add utm params to links
  5. Same steps for notifications

Link should by for example: http://mautic.test/mautic/r/aa84839b312f4ca61e81fd524?ct=YTo1OntzOjY6InNvdXJjZSI7TjtzOjU6ImVtYWlsIjtOO3M6NDoic3RhdCI7czoxNDoieHh4eHh4eHh4eHh4eHgiO3M6NDoibGVhZCI7aTowO3M6NzoiY2hhbm5lbCI7YToxOntzOjU6ImVtYWlsIjtpOjM1O319&utm_medium=mediumtest&utm_name=nametest&utm_content=content+test&utm_source=sourcetest

image

@kuzmany kuzmany changed the title from Google Analytics UTM tags for channels to Google Analytics UTM tags for emails Apr 29, 2017

@kuzmany

This comment has been minimized.

Show comment
Hide comment
@kuzmany

kuzmany Apr 29, 2017

Contributor

@escopecz
Ready to test.
I decide create most requested support UTM tags for emails.
Also added migrations.
My tests works 👍

Contributor

kuzmany commented Apr 29, 2017

@escopecz
Ready to test.
I decide create most requested support UTM tags for emails.
Also added migrations.
My tests works 👍

@escopecz escopecz added Ready To Test and removed WIP labels May 2, 2017

@escopecz escopecz added this to the 2.9.0 milestone May 2, 2017

@escopecz

I quickly went through the code and found several small issues.

@kuzmany

This comment has been minimized.

Show comment
Hide comment
@kuzmany

kuzmany May 2, 2017

Contributor

Fixed

Contributor

kuzmany commented May 2, 2017

Fixed

@kuzmany kuzmany changed the title from Google Analytics UTM tags for emails to Google Analytics UTM tags for emails and notifications Jun 10, 2017

@escopecz escopecz self-assigned this Jun 19, 2017

@escopecz

This comment has been minimized.

Show comment
Hide comment
@escopecz

escopecz Jun 19, 2017

Contributor

Please look at the conflicts and Travis tests here too.

Contributor

escopecz commented Jun 19, 2017

Please look at the conflicts and Travis tests here too.

@alanhartless alanhartless self-assigned this Jun 21, 2017

Merge branch 'staging' into kuzmany-utm-support
# Conflicts:
#	app/bundles/EmailBundle/EventListener/BuilderSubscriber.php
@alanhartless

This comment has been minimized.

Show comment
Hide comment
@alanhartless

alanhartless Jun 26, 2017

Contributor

@escopecz can you take another look at this and adjust your review?

Contributor

alanhartless commented Jun 26, 2017

@escopecz can you take another look at this and adjust your review?

@matishaladiwala matishaladiwala self-assigned this Jun 28, 2017

@matishaladiwala

This comment has been minimized.

Show comment
Hide comment
@matishaladiwala

matishaladiwala commented Jun 28, 2017

approved

@alanhartless alanhartless merged commit 985bc89 into mautic:staging Jun 28, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@pmgl24

This comment has been minimized.

Show comment
Hide comment
@pmgl24

pmgl24 Aug 4, 2017

Hi Kuzmany, nice work ! Is it possible to remplace utm_name by utm_campaign ?
utm_name no longer exists since 2012 and Analytics does not understand correctly this variable.

pmgl24 commented Aug 4, 2017

Hi Kuzmany, nice work ! Is it possible to remplace utm_name by utm_campaign ?
utm_name no longer exists since 2012 and Analytics does not understand correctly this variable.

@kuzmany

This comment has been minimized.

Show comment
Hide comment
@kuzmany

kuzmany Aug 7, 2017

Contributor

@pmgl24 this should fix it #4605.
Can you test it and send comment to that PR?
Thank you for report

Contributor

kuzmany commented Aug 7, 2017

@pmgl24 this should fix it #4605.
Can you test it and send comment to that PR?
Thank you for report

@kuzmany kuzmany deleted the kuzmany:utm-support branch Apr 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment