Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DEC tab for code mode #4001

Merged
merged 1 commit into from May 5, 2017
Merged

Fix DEC tab for code mode #4001

merged 1 commit into from May 5, 2017

Conversation

virlatinus
Copy link
Contributor

Q A
Bug fix? Y
New feature? N
Related user documentation PR URL N/A
Related developer documentation PR URL N/A
Issues addressed (#s or URLs) N/A
BC breaks? N/A
Deprecations? N/A

Description:

This PR fixes an issue where the Dynamic Email Content Tab is not visible when selecting the Code Mode Template.

Steps to reproduce the bug:

  1. Create or Edit an Email
  2. Select Code Mode Template
  3. The DEC tab is not visible and there is no way to edit dynamic content

Steps to test this PR:

  1. Apply this PR
  2. Create or Edit an Email
  3. Select Code Mode Template
  4. The DEC tab is now visible and the dynamic content can be edited

@virlatinus virlatinus added this to the 2.8.1 milestone May 5, 2017
@virlatinus virlatinus added the ready-to-test PR's that are ready to test label May 5, 2017
@escopecz escopecz added the bug Issues or PR's relating to bugs label May 5, 2017
@escopecz escopecz self-assigned this May 5, 2017
escopecz
escopecz approved these changes May 5, 2017
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

@escopecz escopecz added the pending-test-confirmation PR's that require one test before they can be merged label May 5, 2017
@escopecz escopecz mentioned this pull request May 5, 2017
Closed
@dongilbert dongilbert self-assigned this May 5, 2017
@dongilbert
Copy link
Member

+1 Works as described!

@dongilbert dongilbert merged commit d8bbf6c into mautic:staging May 5, 2017
@virlatinus virlatinus deleted the bugfix-dec-codemode branch May 9, 2017 15:37
@npracht npracht mentioned this pull request Jul 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees

@dongilbert dongilbert

@escopecz escopecz

Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Milestone
2.8.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@virlatinus @dongilbert @escopecz @wgxo