New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #5103 - Company/Accounts being duplicated on CRM Sync o… #5610
Fix for issue #5103 - Company/Accounts being duplicated on CRM Sync o… #5610
Conversation
…Sync of edited Company/Account
…Sync of edited Company/Account - Adding correct syntax for elseif structure after Travis CI build failed for PHP 7.1
/label bug |
/label ready to test |
/unlabel ready to test |
/label pending test confirmation |
Please let me know if there is anything else that I can do on this issue/pull request to make sure it gets included in a future release. Thanks. |
Tested, working as expected. Companies are fetching WITH and WITHOUT email addresses, no duplicates and attaching contacts in Mautic - GREAT WORK!!! |
@KaKite - thanks for testing and putting a comment here. @dbhurley, @alanhartless - would there be any reason why this fix (and possibly #5615) could not be put into the 2.13.0 milestone? I ask because we are trying not to diverge from the standard Mautic releases and these are mission critical for us. Thanks in advance for your time and help in letting me know. |
@stancel I'm going to have to push this to 2.14 (which shouldn't be too long in coming) - we're closing up 2.13.1 and this hasn't gotten any updates. |
…Sync of edited Company/Account
…Sync of edited Company/Account
…Sync of edited Company/Account - Adding correct syntax for elseif structure after Travis CI build failed for PHP 7.1
…is CI PHP 7.1 tests
…is CI PHP 7.1 tests
Merge branch 'duplicated-companies-created-fix' of github.com:ProcessFast/mautic into duplicated-companies-created-fix
@dbhurley - please find the rebased updates pushed and let me know if anything else is needed. Thanks. |
@stancel I think something is still off here. It shouldn't be including commits already in master. What branch did you rebase to? |
…f edited Company/Account
Description:
Like the reporter of #5103 we were seeing duplicate Mautic Company records being created when a SuiteCRM Account (Company) was edited. After debugging through this it was discovered that inside IdentifyCompanyHelper::identifyLeadsCompany class and method there was an else if statement for looking up a company name (not domain) through the MX records of the companyemail field. If anything was in that field it correctly skipped the next else if statement where the existing Mautic company would have been looked up by the 'companyname' field.
The proper ordering should be to first lookup my the name then companyname fields. I believe that the else if check put in to lookup the domain should be assigned to the $companyDomain variable instead of the $companyName variable and have made that adjustment in this pull request as well. Making these adjustments corrected the issue when testing in my local environment. Please let me know if you have any questions or feedback.
Steps to reproduce the bug:
mautic:integration:fetchleads --integration=Sugarcrm --time-interval="1 minute"
commandmautic:integration:fetchleads --integration=Sugarcrm --time-interval="1 minute"
command againSteps to test this PR:
List deprecations along with the new alternative:
List backwards compatibility breaks: