Forms contact tab #5685

kuzmany · 2018-02-06T23:20:22Z

Q	A
Bug fix?
New feature?	y
Automated tests included?
Related user documentation PR URL	mautic/documentation#265
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Bugfix/feature donate by www.newcom4u.ch

Description:

PR added forms as tab to contacts detail page.
Also PR add new option to forms - "Show results in contacts tab"
This feature allow users add relevant forms contact result to details (for example - orders, reservation etc)

Steps to test this PR:

Apply PR and run DB migration php app/console doctrine:migrations:migrate or php app/console doctrine:schema:update --force
Create form and enable option "Show results in contacts tab"
Send form
Go to contacts detail page and see if new tab Forms is showed with relevant data
Test case If contact don't have any forms fill
Test case If Mautic user don't have permission don't see forms

kuzmany · 2018-02-06T23:20:33Z

Label: Feature request

kuzmany · 2018-02-06T23:20:41Z

Label: WIP

kuzmany · 2018-02-08T01:50:59Z

Label: WIP

kuzmany · 2018-02-08T01:51:06Z

Label: Ready to test

tpilet

I test everything is ok

tpilet · 2018-02-09T06:02:00Z

Tested. Works properly +1“

escopecz

I noticed a few issues. Please look at them. Also I'm worried that this doesn't have pagination. It has hard-coded limit of 999 rows. It can take some time to load all those data considering all the data that the contact detail page is already loading.

escopecz · 2018-03-22T10:38:28Z

app/bundles/FormBundle/Entity/Form.php

+        $builder->createField('inContactTab', 'boolean')
+            ->columnName('in_contact_tab')
+            ->nullable()
+            ->build();


This could be a one liner. See for example https://github.com/mautic/mautic/blob/staging/app/bundles/WebhookBundle/Entity/Log.php#L73.

escopecz · 2018-03-22T10:40:35Z

app/bundles/FormBundle/Entity/Form.php

+    /**
+     * @return mixed
+     */
+    public function getInContactTab()


Does it really return mixed? The $inContactTab property is annotated as bool. (the same in the setter)

If it will be bool, it would be nice to call this method isInContactTab() as it makes it more human friendly :)

escopecz · 2018-03-22T10:45:20Z

app/bundles/FormBundle/Model/SubmissionModel.php

+
+    /**
+     * Return Forms with results to contacts tab
+     *ľ.


What is this Slovak weirdo doing here? 🤣 (and bellow too)

escopecz · 2018-03-22T10:46:06Z

app/bundles/FormBundle/Model/SubmissionModel.php

+     * Return Forms with results to contacts tab
+     *ľ.
+     *
+     * @param null $leadId


This type hint should have been int|null, right?

escopecz · 2018-03-22T10:49:17Z

app/bundles/FormBundle/Model/SubmissionModel.php

+            'RETURN_ARRAY'
+        );
+        if ($permissions['form:forms:viewown'] || $permissions['form:forms:viewother']) {
+            if (!$permissions['form:forms:viewother']) {


Is the first if necessary here?

It's from here. I am gonna fixed it

mautic/app/bundles/FormBundle/EventListener/SearchSubscriber.php

Line 71 in afb4da4

$permissions = $security->isGranted(['form:forms:viewown', 'form:forms:viewother'], 'RETURN_ARRAY');

Maxell92 · 2018-03-26T11:58:07Z

This PR works, great job @kuzmany.

Can you add a documentation? We can merge it then.

kuzmany · 2018-03-26T13:40:40Z

@Maxell92 thanks, docs added mautic/documentation#265

Label: Pending feedback

Maxell92 · 2018-03-26T15:43:52Z

Great, thank you. We will merge it after all issues in that PR will be solved :)

alanhartless · 2018-03-26T21:48:25Z

Questions on this. What is the use of this one when this exact same data is displayed in the History tab? If you click the button on the left of the timeline entry for the form results, it displays the form result data.

dbhurley · 2018-03-27T13:27:04Z

This is not something that belongs in core as a new feature. Alan has correctly identified the reason behind this.

dbhurley · 2018-03-27T13:28:48Z

My suggestion would be to create a plugin for this behavior if it's still desired.

kuzmany · 2018-03-31T05:18:01Z

Why you don't vote to community if they interest to the feature? Feature is useful, with better UX and you selective forms, instead timeline views. This PR added little touch of CRM, you can attach to profile Orders, Contacts, Request a demo etc. In future we can expend this PR with many other features.

Maybe you can create channel when you get feedback before PR is done (ready to commit with the documentation). We should save a lot of time.

Hope @tpilet or @npracht appreciate that.

alanhartless · 2018-03-31T05:21:23Z

So how is this different than what is already shown in the History tab for form submission entries though? This at face value is a duplicate feature for what’s already there.

Also keep in mind that this is a marketing automation project, not a CRM. It’s not in interest of the project to make it a CRM.

kuzmany · 2018-03-31T05:26:29Z

You can choose relevant forms. Many forms we use, just few are relevant to contact for company business. Maybe you can ask non-tech people which variant do they like. I bet, If they want work with certain contact, this PR is more helpful like timeline entries.

alanhartless · 2018-03-31T05:32:19Z

Yes but there are lots of relevant parts of Mautic and forms are just part of it. Some may put more value on emails opened or assets downloaded or campaigns over forms submitted. At some point, displaying the same data in multiple places will become bloatware.

tpilet · 2018-03-31T06:26:53Z

The goal of this function its to can see clearly some info like all the reservations i v done all the orders i ve done we plan to use this info intensevly in our strategy in the future alan if you want we can have a talk. I think it not a redudsncy but a function easy to use for the customer. Envoyé de mon iPhone

…

Le 31 mars 2018 à 07:32, Alan Hartless ***@***.***> a écrit : Yes but there are lots of relevant parts of Mautic and forms are just part of it. Some may put more value on emails opened or assets downloaded or campaigns over forms submitted. At some point, displaying the same data in multiple places will become bloatware. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

alanhartless · 2018-03-31T13:35:04Z

I can understand the value in that. But that’s your specific marketing strategy. I’ve seen a lot of marketing done through Mautic that does not rely on forms as different marketers put an emphasis on different parts of Mautic. This would only benefit a subset of the marketers leveraging your same strategy.

That’s why we feel this would be better suited as a plug-in since it’s replicating the information already displayed in the same page but adds emphasize to the data for a specific marketing strategy.

kuzmany · 2018-05-15T08:31:49Z

Finally bring this feature as plugin https://github.com/kuzmany/mautic-extendee-form-tab-bundle

Show in contacts tab option in form

bb709ca

mautibot added the code-review-needed PR's that require a code review before merging label Feb 6, 2018

mautibot added the feature A new feature for inclusion in minor or major releases label Feb 6, 2018

mautibot added the WIP PR's that are not ready for review and are currently in progress label Feb 6, 2018

kuzmany added 6 commits February 7, 2018 01:23

Another work on form tab

20c7369

Minor

c9960a2

Final

67b8776

Minor

373dd59

Add permission

e5f2858

Minor final

5b90ae3

mautibot removed the WIP PR's that are not ready for review and are currently in progress label Feb 8, 2018

mautibot added the ready-to-test PR's that are ready to test label Feb 8, 2018

kuzmany added 2 commits February 8, 2018 10:35

Improve zero results and minor UX

1c7d54b

Remove buttons

f7e8741

mautibot removed the code-review-needed PR's that require a code review before merging label Feb 9, 2018

tpilet approved these changes Feb 9, 2018

View reviewed changes

dbhurley added this to the 2.13.0 milestone Mar 4, 2018

escopecz self-assigned this Mar 22, 2018

escopecz requested changes Mar 22, 2018

View reviewed changes

mautibot added the pending-test-confirmation PR's that require one test before they can be merged label Mar 22, 2018

escopecz added pending-feedback PR's and issues that are awaiting feedback from the author and removed ready-to-test PR's that are ready to test labels Mar 22, 2018

kuzmany added 3 commits March 22, 2018 16:08

Fix from review

4d349df

Added default switch to No

d16e358

Limit results from 999 to 99 (Wayne Gretzky commit)

decaed4

Maxell92 self-assigned this Mar 26, 2018

Maxell92 approved these changes Mar 26, 2018

View reviewed changes

mautibot added the code-review-needed PR's that require a code review before merging label Mar 26, 2018

kuzmany mentioned this pull request Mar 26, 2018

Forms contact tab mautic/documentation#265

Closed

mautibot removed the pending-feedback PR's and issues that are awaiting feedback from the author label Mar 26, 2018

alanhartless added pending-feedback PR's and issues that are awaiting feedback from the author and removed ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged labels Mar 26, 2018

alanhartless removed this from the 2.13.0 milestone Mar 26, 2018

dbhurley closed this Mar 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Forms contact tab #5685

Forms contact tab #5685

kuzmany commented Feb 6, 2018 •

edited

kuzmany commented Feb 6, 2018

kuzmany commented Feb 6, 2018

kuzmany commented Feb 8, 2018

kuzmany commented Feb 8, 2018

tpilet left a comment

tpilet commented Feb 9, 2018

escopecz left a comment

escopecz Mar 22, 2018

escopecz Mar 22, 2018

escopecz Mar 22, 2018 •

edited

escopecz Mar 22, 2018

escopecz Mar 22, 2018

kuzmany Mar 22, 2018

Maxell92 commented Mar 26, 2018

kuzmany commented Mar 26, 2018 •

edited

Maxell92 commented Mar 26, 2018

alanhartless commented Mar 26, 2018 •

edited

dbhurley commented Mar 27, 2018

dbhurley commented Mar 27, 2018

kuzmany commented Mar 31, 2018

alanhartless commented Mar 31, 2018

kuzmany commented Mar 31, 2018

alanhartless commented Mar 31, 2018

tpilet commented Mar 31, 2018 via email

alanhartless commented Mar 31, 2018

kuzmany commented May 15, 2018

Forms contact tab #5685

Forms contact tab #5685

Conversation

kuzmany commented Feb 6, 2018 • edited

Description:

Steps to test this PR:

kuzmany commented Feb 6, 2018

kuzmany commented Feb 6, 2018

kuzmany commented Feb 8, 2018

kuzmany commented Feb 8, 2018

tpilet left a comment

Choose a reason for hiding this comment

tpilet commented Feb 9, 2018

escopecz left a comment

Choose a reason for hiding this comment

escopecz Mar 22, 2018

Choose a reason for hiding this comment

escopecz Mar 22, 2018

Choose a reason for hiding this comment

escopecz Mar 22, 2018 • edited

Choose a reason for hiding this comment

escopecz Mar 22, 2018

Choose a reason for hiding this comment

escopecz Mar 22, 2018

Choose a reason for hiding this comment

kuzmany Mar 22, 2018

Choose a reason for hiding this comment

Maxell92 commented Mar 26, 2018

kuzmany commented Mar 26, 2018 • edited

Maxell92 commented Mar 26, 2018

alanhartless commented Mar 26, 2018 • edited

dbhurley commented Mar 27, 2018

dbhurley commented Mar 27, 2018

kuzmany commented Mar 31, 2018

alanhartless commented Mar 31, 2018

kuzmany commented Mar 31, 2018

alanhartless commented Mar 31, 2018

tpilet commented Mar 31, 2018 via email

alanhartless commented Mar 31, 2018

kuzmany commented May 15, 2018

kuzmany commented Feb 6, 2018 •

edited

escopecz Mar 22, 2018 •

edited

kuzmany commented Mar 26, 2018 •

edited

alanhartless commented Mar 26, 2018 •

edited