Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new GROUP_CONCAT function to reports #6289

Merged
merged 10 commits into from Sep 4, 2018

Conversation

Projects
None yet
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Jul 4, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6198
BC breaks?
Deprecations?

Description:

Based on this issue #6198
Reports with join tables and multiple results give multiple rows for on contact.
This PR added GROUP_CONCAT function allow add column with coma separated results in one row (for example companies to one line to concat)
More https://dev.mysql.com/doc/refman/8.0/en/group-by-functions.html#function_group-concat

Before

image

After
image

Steps to test this PR:

  1. Create contact with two or more assign companies and submit form with his ID
  2. Create form submisision report
  3. Setup like me on screenshot

image

  1. Expect this column (separated values with comma)
    image

kuzmany added some commits Jul 4, 2018

kuzmany added some commits Jul 4, 2018

Revert "Prevent and check columns also in filters, group by or aggreg…
…ators, not just columns"

This reverts commit 2b804b3.
Revert "Documentation update"
This reverts commit 2459154.
Merge branch 'staging' of https://github.com/mautic/mautic into fix-r…
…eports-duplicate-with-company-submissions

# Resolved conflicts:
#	app/bundles/LeadBundle/Tests/EventListener/SegmentReportSubscriberTest.php
#	app/bundles/ReportBundle/Event/ReportGeneratorEvent.php

@kuzmany kuzmany added this to the 2.14.1 milestone Jul 19, 2018

@heathdutton

This comment has been minimized.

Copy link
Member

heathdutton commented Sep 4, 2018

Works as designed, and useful!

screen shot 2018-09-04 at 9 03 19 am

screen shot 2018-09-04 at 9 04 47 am

@heathdutton heathdutton merged commit 70e5c45 into mautic:staging Sep 4, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.