Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check DoNotContact by Lead not Email in contact detail #6297

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
4 participants
@kuzmany
Copy link
Contributor

kuzmany commented Jul 6, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #5949
BC breaks?
Deprecations?

Description:

LeadController use check DoNotContact flag based on email address. But Mautic usually use DoNotContact flag assign to Lead entity/ID. This PR rewrite this logic in Lead details

Steps to reproduce the bug:

  1. Create a contact
  2. Send email to this contact and unsubscribe from email
  3. Create a new contact with same email address (a duplicate)
  4. See in the contact list that first contact is set DNC with logo but duplicate one is not
    image
  5. Go on the duplicate contact and see that tag DNC is displayed
    image
  6. Display contact preferences and see that email is checked
    image

Steps to test this PR:

  1. Repeat all steps
  2. See flag just for contact with DoNotContact result

@kuzmany kuzmany changed the title Check DoNotContact by Lead not email Check DoNotContact by Lead not Email in contact detail Jul 6, 2018

@kuzmany kuzmany added this to the 2.14.1 milestone Jul 19, 2018

@npracht npracht self-requested a review Aug 8, 2018

@npracht npracht self-assigned this Aug 8, 2018

@npracht

npracht approved these changes Aug 8, 2018

Copy link
Member

npracht left a comment

I just realized that we're using it on prod environment for some weeks and it works properly :D

@heathdutton heathdutton merged commit e257299 into mautic:staging Sep 4, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.