Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global_only from campaign segments condition #6312

Closed
wants to merge 1 commit into
base: staging
from

Conversation

Projects
None yet
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Jul 11, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Yes
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Contact segments condition show only globa segmetns. This PR fixed it

Steps to reproduce the bug:

  1. Create two segments - with global only option enabled/disabled
  2. Create campaign with Contact segments condition - see just global only segment in condition

Steps to test this PR:

  1. Repeat all steps
  2. See all segments in condition. Now works properly

@kuzmany kuzmany modified the milestones: 2.14.0, 2.14.1 Jul 11, 2018

@alanhartless

This comment has been minimized.

Copy link
Contributor

alanhartless commented Jul 11, 2018

@kuzmany see the conversations in this closed PR that attempted this same change. #5660

@alanhartless

This comment has been minimized.

Copy link
Contributor

alanhartless commented Jul 11, 2018

And #5658

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Jul 12, 2018

@npracht

I suggest:

  1. Add new options System segments (same like System report) (migrate all public/non public settings to that)

image

  1. Current Public yes/no option rename to Show in preferences center

What do you think?

As I understand now public is the same feature like System report in reports. And we need add ability edit certain segments for contacts in preferences center (I use it in that way currently)

@npracht

This comment has been minimized.

Copy link
Member

npracht commented Jul 12, 2018

Agree to have 2 YES/NO features:

  • System (available to everyone or not)
  • Visible in PC (its name is selfcarriing)

@kuzmany kuzmany removed the Ready To Test label Jul 19, 2018

@kuzmany kuzmany removed this from the 2.14.1 milestone Jul 19, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Jul 25, 2018

Closed, no feedback for moving to create solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.