Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Campaign form field value condition options and new operators #6314

Merged
merged 2 commits into from Sep 4, 2018

Conversation

Projects
None yet
6 participants
@kuzmany
Copy link
Contributor

kuzmany commented Jul 12, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Yes
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6299
BC breaks?
Deprecations?

Description:

Related to issue #6299
Added to CampaignEventFormFieldValueType support for both type of properties array for options (list and optionlist)
This PR also added starts with, ends with and contains operator. This update allow use condition with multiple selected choice. If contact select more choices (second,third) at the moment there no operator for control exist one value.

image

Before

Selected second,third equal third (FALSE)
Selected second,third like third (FALSE)
etc

AFTER

Selected second,third contains third (TRUE)

Steps to reproduce the bug:

  1. Create form with multiple choices (checkboxes) option field
  2. Go to campaigns and create campaign with form value condition and choose multiple choices option
  3. See selectbox with options as value
  4. Save and then reopen condition
  5. Values is not options but text input

Steps to test this PR:

  1. Repeat all steps
  2. See if selectbox is loaded after re-open condition
  3. Then test new form value condition operators: starts/ends with, contains

image

@kuzmany kuzmany added this to the 2.14.1 milestone Jul 12, 2018

@kuzmany kuzmany changed the title Fix: Campaign form field condition options and new operators Fix: Campaign form field value condition options and new operators Jul 12, 2018

@johbuch

This comment has been minimized.

Copy link

johbuch commented Jul 16, 2018

@kuzmany
I tested and it works.
But I just saw something.
It only works if in the form, the checkbox group field is set on NO (on the properties tab). Mean we have to create the values
image
If set on YES, it doesn't work

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Jul 16, 2018

I did test and works both, also contains condition

@YosuCadilla

This comment has been minimized.

Copy link

YosuCadilla commented Aug 9, 2018

I have tested the 5 steps with conditions Starts with, Contains and Ends with.
In all 3 cases the Value field was a dropdown (not a free text box).

@npracht

npracht approved these changes Aug 9, 2018

@heathdutton heathdutton merged commit 99b7b86 into mautic:staging Sep 4, 2018

2 checks passed

Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.