Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Stop sending unpublished notifications #6328

Merged
merged 4 commits into from Sep 4, 2018

Conversation

Projects
None yet
4 participants
@kuzmany
Copy link
Contributor

kuzmany commented Jul 16, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Yes
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Unpublished notification still campaign sent. This PR fixed it

Steps to reproduce the bug:

  1. Send unpublished notification by campaign
  2. Notification send even is unpublished

Steps to test this PR:

  1. Same test workflow

@kuzmany kuzmany added this to the 2.14.1 milestone Jul 16, 2018

@npracht npracht self-requested a review Aug 8, 2018

@npracht npracht self-assigned this Aug 8, 2018

@npracht

npracht approved these changes Aug 8, 2018

Copy link
Member

npracht left a comment

☮️

@heathdutton heathdutton merged commit 3dd8a90 into mautic:staging Sep 4, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.