Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Notifciation list ordering #6346

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
4 participants
@kuzmany
Copy link
Contributor

kuzmany commented Jul 22, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Noticed ordering in notification indexAction doesn't work.
This PR added setListFilters for store filter information to sesssion.

Steps to reproduce the bug:

  1. Go to Web notifications and create 2 notification
  2. Try order by ID
  3. See nothing happend

Steps to test this PR:

  1. Repeat all steps
  2. See If works like in other controller (Email for example)

@kuzmany kuzmany added this to the 2.14.1 milestone Jul 22, 2018

@dongilbert
Copy link
Member

dongilbert left a comment

+1 brings into line with other list controller indexAction methods

@heathdutton

This comment has been minimized.

Copy link
Member

heathdutton commented Sep 4, 2018

Before testing this I didn't even know this functionality existed O_O

@heathdutton heathdutton merged commit bfdf860 into mautic:staging Sep 4, 2018

2 checks passed

Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.