Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repeatable points action #6388

Merged
merged 5 commits into from Nov 10, 2018

Conversation

Projects
6 participants
@kuzmany
Copy link
Contributor

kuzmany commented Jul 30, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Points action are executable just one time.
This PR allow repeat executions for points action, for example visits a page.

image

Steps to test this PR:

  1. Create Visits specific URL Point action
  2. Execute action more times
  3. See action was execute just one time
  4. Enable new option: Allow repeat the action
  5. Execute action one or more times
  6. See IF on each run of action, points are executable

kuzmany added some commits Jul 30, 2018

kuzmany added some commits Jul 30, 2018

@Woeler

This comment has been minimized.

Copy link
Member

Woeler commented Jul 30, 2018

I love this!

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Jul 30, 2018

@Woeler If you like, please test and write comment ;) Help speed up merge it ;)

@luizeof

This comment has been minimized.

Copy link

luizeof commented Jul 31, 2018

@kuzmany Great feature! Thank you!

When create a new point action, no default boolean value is passed to toggle

download 1

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Jul 31, 2018

@luizeof Fixed, thanks

@LevryKurniawan
Copy link
Contributor

LevryKurniawan left a comment

Very good. @npracht Can this be added to 2.14.1?

@johbuch

This comment has been minimized.

Copy link

johbuch commented Aug 16, 2018

just tested with mautibox with form submissions --> works perfectly
great enhancement ;)

@Woeler

Woeler approved these changes Oct 15, 2018

Copy link
Member

Woeler left a comment

Same for me, works great. This is a killer feature @kuzmany !

@npracht npracht added this to Tested once in Testing 2.15.0 Oct 16, 2018

@npracht npracht moved this from Tested once to Ready to commit in Testing 2.15.0 Oct 23, 2018

@Woeler Woeler merged commit 1ff9ef6 into mautic:staging Nov 10, 2018

2 checks passed

Scrutinizer Analysis: 7 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Testing 2.15.0 automation moved this from Ready to commit to Merged Nov 10, 2018

@Woeler Woeler removed the Ready To Commit label Nov 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.